Skip to content

Better suport custom & plugin algos#117

Merged
nicolasservel merged 5 commits intomasterfrom
enhancement/dss90-better-suport-custom-plugin-algos
Jan 22, 2021
Merged

Better suport custom & plugin algos#117
nicolasservel merged 5 commits intomasterfrom
enhancement/dss90-better-suport-custom-plugin-algos

Conversation

@nicolasservel
Copy link
Contributor

@nicolasservel nicolasservel commented Jan 19, 2021 •
edited
Loading

See ch59584

This PR:

  • adds better support for plugin & custom algorithms in the ML helpers, in particular when listing & getting algorithm settings
  • adds support for wait_guess_complete when creating clustering ML Task, to align with prediction MLTasks for which it is already available, and changes the default behavior to wait_guess_complete=True, which is what we want in the vast majority of cases
  • fixes a few things found while testing:
    • no fail if "plugin_python" key not in modeling, for clustering task when disable_all_algorithms
    • only register "impurity" for MLlib Random Forest, duplication previously broke instantiation of the algorithm settings

@nicolasservel nicolasservel added this to the 9.0 milestone Jan 19, 2021
@nicolasservel nicolasservel self-assigned this Jan 19, 2021
@shortcut-integration
Copy link

shortcut-integration bot commented Jan 19, 2021

This pull request has been linked to Clubhouse Story #59584: Better support for custom & plugin algos in public ML api helpers.

instanceofme
instanceofme approved these changes Jan 19, 2021
View reviewed changes
@instanceofme instanceofme changed the title Better suport custom plugin algos Better suport custom & plugin algos Jan 19, 2021
@nicolasservel @instanceofme
Better naming in comments
b38b38f 
Co-authored-by: Adrien Lavoillotte <adrien.lavoillotte@dataiku.com>
mhham
mhham approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@mhham mhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks

samronsin
samronsin requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@samronsin samronsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix the _get_plugin_algorithm_names method which breaks get_all_possible_algorithm_names and its downstream methods with Python 3.

@nicolasservel @samronsin
Fix listing algos in py3 & remove typo
3d75fcf 
Co-authored-by: Samuel O. Ronsin <samuel.ronsin@dataiku.com>
samronsin
samronsin approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@samronsin samronsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@nicolasservel nicolasservel merged commit 3e60674 into master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@instanceofme instanceofme instanceofme approved these changes

@samronsin samronsin samronsin approved these changes

@mhham mhham mhham approved these changes

Assignees

@nicolasservel nicolasservel

Labels

type-enhancement

Projects

None yet

Milestone

9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolasservel @instanceofme @samronsin @mhham